Test suite fixes #67
Merged
Test suite fixes #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good start, i'll merge. I believe that you have already finished the stack HTTP request mocking? Or should I get to work on that. |
|
HTTP request mocking is done as well. I'll open it as soon as this one is merged. |
|
2 seconds late! |
|
Haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed up all the failing tests in the test suite. Running
python tests/unit_tests.pyfrom the project root yields a fully passing test suite, for me anyway. I think depending on you geographical location, some tests might still fail, because the tests are making live HTTP requests and certain news sites serve up different content depending on where you're browsing from.However, I think this is a good start. The next step is to mock out any HTTP requests and respond with a static response -- a local HTML file. I'm already working on that as well.
Let me know if it looks good or if you want anything changed.