Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: setCursor doesn't work well with inputStyle: "contenteditable", #6168

Closed
wants to merge 4 commits into from
Closed

Fix: setCursor doesn't work well with inputStyle: "contenteditable", #6168

wants to merge 4 commits into from

Commits on Mar 10, 2020

  1. Unnecessary code 

    The condition `op.focus == activeElt()` seems that it will be always `false` because `op.focus` is `boolean` and `activeElt()` returns an HTMLElement.

```
HTMLElement == true
false
HTMLElement == false
false
document.body == true
false
document.body == false
false
```

`activeElt()` always return an `HTMLElement`.
https:/codemirror/CodeMirror/blob/28568ba037146b2d13857849650db94b8ec09385/src/util/dom.js#L67-L80
    @A-312
    A-312 committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    f0eccc8 View commit details
    Browse the repository at this point in the history

  2. add spellchecker demo

    @A-312
    A-312 committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    c8f0a0e View commit details
    Browse the repository at this point in the history

  3. Fix showPrimarySelection focus

    @A-312
    A-312 committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    8c07543 View commit details
    Browse the repository at this point in the history

  4. Add options.forceFocus for getSelection and getCursor 

    Give the editor focus after selection.
    @A-312
    A-312 committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    a2a3298 View commit details
    Browse the repository at this point in the history