Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Fold Missing Scrollbar Annotation #6385

Closed
tokafew420 opened this issue Aug 17, 2020 · 1 comment
Closed

Code Fold Missing Scrollbar Annotation #6385

tokafew420 opened this issue Aug 17, 2020 · 1 comment

Comments

@tokafew420
Copy link
Contributor

The scrollbar annotation doesn't show a match when used with the code folding addon in the following scenarios:

  • If there is a match on the folded line and there are also matches within the folded content then when the fold is collapsed, we expect at least the match on folded line to be annotated on scrollbar. But it's not.
  • Matches hidden within a collapsed fold are not annotated on the scrollbar.

See Fiddle: https://jsfiddle.net/tokafew420/1exL7kqb/

Expanded
image

Collapsed
image

I guess technically the second scenario is not a bug but rather just how the AnnotateScrollbar addon works however it's not what I was expecting.

I'm looking into a possible solution however I thought I'd create this issue in case there's already a fix for this or if someone has insights into how it can be fixed.

Codemirror: 5.56.0
Broswer: Google Chrome 84.0.4147.125

@tokafew420
Copy link
Contributor Author

Closing. Fixed with commit ac4aaa0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant