Make membership unique per user and facility/org #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophmeissner
force-pushed
the
feature/492-make-membership-unique
branch
from
c6142d6
to
3841372
Compare
christophmeissner
force-pushed
the
feature/492-make-membership-unique
branch
from
3841372
to
1e9f8df
Compare
It comes with a rather lengthy data migration for FacilityMembership and OrganizationMembership: Duplicate memberships are squashed, keeping only the membership per user and facility/org with the highest (max) status, and if equal, with the highest (min) role. If the user is no longer an manager or admin of any facility or organization, their `is_staff` flag will be set to `False`. They will no longer be able to use the admin interface (unless manually granted by another admin again). fixes coders4help#492
christophmeissner
force-pushed
the
feature/492-make-membership-unique
branch
from
1e9f8df
to
b5e574a
Compare
pitpalme
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It comes with a rather lengthy data migration for FacilityMembership and OrganizationMembership:
Duplicate memberships are squashed, keeping only the membership per user and facility/org with the highest (max) status, and if equal, with the highest (min) role.
If the user is no longer an manager or admin of any facility or organization, their
is_staffflag will be set toFalse. They will no longer be able to use the admin interface (unless manually granted by another admin again).fixes #492