-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement 2 pairs of inc/dec commands: one shall pad with zeros, another shall not #6
Comments
I think I've implemented this in the padding-tests branch of my fork. It has I'm pretty sure it still has some kinks to work out, though. Edit: pulled into master of my fork, for now. I think most if not all of the "kinks" were present even before my changes. |
My fork has this. There is a variable |
@cofi, out of curiosity, what was the rationale behind this decision?
I'm sure there are pros and cons in both approaches, and padding doesn't always suit as well (see @mlf176f2's PR for just one of many examples).
I think it makes sense to have 2 pairs of commands, one shall pad with zeros, another shall not.
And no need to implement fancy rules to determine, when to use padding.
P.S. This may be better discussed in a separate thread, but currently padding works only for positive numbers, e.g. decrement from
10
gives09
, while increment from-10
gives-9
.The text was updated successfully, but these errors were encountered: