Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable colored output for Scala 2 #2950

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Jan 6, 2024

Fixes #2947

Pull Request: #2950

@@ -534,7 +534,10 @@ class ZincWorkerImpl(
stampReader = Stamps.timeWrapBinaryStamps(converter)
)

val scalaColorProp = "scala.color"
val previousScalaColor = sys.props.get(scalaColorProp).getOrElse("auto")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means, we will later "reset" it to a new value "auto" instead of the original value, in case it was not defined. I'd rather reset to the original, which means we need to unset when it was unset before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you.

@lolgab lolgab marked this pull request as ready for review January 6, 2024 16:21
@lolgab lolgab requested a review from lefou January 6, 2024 19:29
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lolgab lolgab merged commit ecdbf8b into com-lihaoyi:main Jan 6, 2024
38 checks passed
@lefou lefou added this to the 0.11.7 milestone Jan 7, 2024
@lolgab lolgab deleted the fix-#2947 branch March 23, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colors in Scala 2 compile errors are not rendered
2 participants