Detect assemblies with too many entries to fail shell script prepending #3140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the issue of invalid assembly files which occurs when the following two conditions are met:
65535
ZIP entriesThe issue was reported and analyzed in the following tickets:
This issue also hits other build tools, but it seems Mill is the only tools which automatically enables shell script prepending by default.
Since there is no real fix available, we simply try to detect the issue after the fact and fail the assemble task with a actionable error message.
To make the fix binary compatible, I had to deprecated the
upstreamAssembly
target in favor to the newupstreamAssembly2
target, which returns also the added ZIP entry count. Since this can be a behavioral change when users have overridden theupstreamAssembly
target, I also added some warning messages with will detect this at runtime and provide actionable help.