Add Java 21 and 23 to CI #3680
Draft
Add Java 21 and 23 to CI #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lihaoyi
reviewed
Oct 7, 2024
| @@ -64,6 +64,15 @@ jobs: | |||
| - java-version: 17 | |||
| millargs: "contrib.__.testCached" | |||
|
|
|||
| - java-version: 21 | |||
There was a problem hiding this comment.
I'd suggest we pick some of the existing jobs and set them to 21/23. We are already not covering the entire version matrix, and we can't afford to if we want to keep CI times reasonable. So the best we can do is to scatter jobs at various points around the version matrix, which should hopefully be enough to catch most things
There was a problem hiding this comment.
I'm solely interested in what fails and what succeeds. We can optimize the CI setup before we merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.