Push all bytes when reading from a file channel #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the failure appears to be an issue of how mill handles dead symlinks in PathRefs. There's a fix on the way com-lihaoyi/mill#1082. Alternatively, all tests pass with an older version of mill (0.8.0) which however is incompatible with Scala 3.0.0-M2. |
|
Tests now pass with the updated mill version |
|
Can it be related to com-lihaoyi/mill#528 ? We concat some shell script with a jar content. This seem to fail for large (maybe > 100MB) jar files. Here's the code: os.write(output, prependShellScript + lineSep)
os.write.append(output, os.read.inputStream(tmp))
|
|
That's definitely possible. The circumstance that caused be find this bug were in the context of serving a large ~300MB file from cask. |
The FileChannel API makes no gurantees that a single call to "transferTo" will actually transfer all bytes from the file. In particular, if the file is large, it is likely that the desitnation channel will not accept all bytes at once.
jodersky
force-pushed
the
jo/push-all-bytes
branch
from
3241df1
to
2f7ab63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FileChannel API makes no gurantees that a single call to "transferTo" will actually transfer all bytes from the file. In particular, if the file is large, it is likely that the destination channel will not accept all bytes at once.