Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass arguments through create routines to object constructors #23

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Pass arguments through create routines to object constructors #23

merged 3 commits into from
Jan 17, 2023

Conversation

shadowspawn
Copy link
Contributor

@shadowspawn shadowspawn commented Jan 17, 2023 •
edited
Loading

Problem: the global create routines like createCommand were ignoring client arguments and just calling the relevant constructor without any arguments.

Solution: pass through the arguments.

See: #22

abetomo
abetomo approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn merged commit 5ea64e9 into develop Jan 17, 2023
@shadowspawn shadowspawn deleted the feature/fix-create branch January 17, 2023 07:37
@shadowspawn
Copy link
Contributor Author

Thanks @abetomo

@shadowspawn shadowspawn added pending release On a branch for eventual release, but not yet merged to main. and removed pending release On a branch for eventual release, but not yet merged to main. labels Jan 17, 2023
@shadowspawn shadowspawn mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadowspawn @abetomo