fix: only expose error codes

common-voice · Oct 27, 2021 · 2114b38 · 2114b38
1 parent 1937f99
commit 2114b38
Show file tree

Hide file tree

Showing 8 changed files with 38 additions and 38 deletions.
diff --git a/server/routes/languages.js b/server/routes/languages.js
@@ -17,7 +17,7 @@ router.get('/', (req, res) => {
  } catch (error) {
  debug('GET_LANGUAGES_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_LANGUAGES_ERROR' });
  }
 });
 
@@ -29,7 +29,7 @@ router.get('/missing', async (req, res) => {
  } catch (error) {
  debug('GET_MISSING_LANGUAGES_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_MISSING_LANGUAGES_ERROR' });
  }
 });
 
@@ -41,7 +41,7 @@ router.get('/additional', async (req, res) => {
  } catch (error) {
  debug('GET_ADDITIONAL_LANGUAGES_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_ADDITIONAL_LANGUAGES_ERROR' });
  }
 });
 

diff --git a/server/routes/sentences.js b/server/routes/sentences.js
@@ -21,7 +21,7 @@ router.get('/review', async (req, res) => {
  } catch (error) {
  debug('GET_SENTENCES_FOR_REVIEW_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_SENTENCES_FOR_REVIEW_ERROR' });
  }
 });
 
@@ -33,7 +33,7 @@ router.get('/rejected', async (req, res) => {
  .catch((error) => {
  debug('GET_REJECTED_SENTENCES_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_REJECTED_SENTENCES_ERROR' });
  });
 });
 
@@ -45,7 +45,7 @@ router.get('/my', async (req, res) => {
  .catch((error) => {
  debug('GET_MY_SENTENCES_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_MY_SENTENCES_ERROR' });
  });
 });
 
@@ -58,7 +58,7 @@ router.post('/delete', async (req, res) => {
  .catch((error) => {
  debug('DELETE_SENTENCES_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'DELETE_SENTENCES_ERROR' });
  });
 });
 
@@ -73,7 +73,7 @@ router.put('/', async (req, res) => {
  } catch (error) {
  debug('CREATE_SENTENCES_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'CREATE_SENTENCES_ERROR' });
  }
 });
 
@@ -91,7 +91,7 @@ router.get('/:locale', async (req, res) => {
  } catch (error) {
  debug('GET_SENTENCES_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_SENTENCES_ERROR' });
  }
 });
 
@@ -107,7 +107,7 @@ router.get('/text/:locale', async (req, res) => {
  } catch (error) {
  debug('GET_SENTENCES_TEXT_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_SENTENCES_TEXT_ERROR' });
  }
 });
 
@@ -123,7 +123,7 @@ router.get('/text/approved/:locale', async (req, res) => {
  } catch (error) {
  debug('GET_APPROVED_SENTENCES_TEXT_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_APPROVED_SENTENCES_TEXT_ERROR' });
  }
 });
 
@@ -139,7 +139,7 @@ router.get('/text/undecided/:locale', async (req, res) => {
  } catch (error) {
  debug('GET_UNDECIDED_SENTENCES_TEXT_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_UNDECIDED_SENTENCES_TEXT_ERROR' });
  }
 });
 
@@ -155,7 +155,7 @@ router.get('/text/rejected/:locale', async (req, res) => {
  } catch (error) {
  debug('GET_UNDECIDED_SENTENCES_TEXT_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_UNDECIDED_SENTENCES_TEXT_ERROR' });
  }
 });
 
@@ -171,7 +171,7 @@ router.get('/sources/:locale', async (req, res) => {
  } catch (error) {
  debug('GET_SENTENCES_SOURCES_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_SENTENCES_SOURCES_ERROR' });
  }
 });
 

diff --git a/server/routes/stats.js b/server/routes/stats.js
@@ -38,7 +38,7 @@ router.get('/', async (req, res) => {
  } catch (error) {
  debug('GET_STATS_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_STATS_ERROR' });
  }
 });
 
@@ -53,7 +53,7 @@ router.get('/general/:localeId', async (req, res) => {
  } catch (error) {
  debug('GET_STATS_FOR_LANGUAGE_ERROR', error);
  res.status(STATUS_ERROR);
- res.json({ message: error.message });
+ res.json({ message: 'GET_STATS_FOR_LANGUAGE_ERROR' });
  }
 });
 

diff --git a/server/routes/users.js b/server/routes/users.js
@@ -44,7 +44,7 @@ router.post('/settings', async (req, res) => {
  res.json({});
  } catch (error) {
  res.status(500);
- res.json({ message: error.message });
+ res.json({ message: 'UPDATE_SETTINGS_ERROR' });
  }
 });
 
@@ -63,7 +63,7 @@ router.put('/languages', async (req, res) => {
  res.json(updatedLanguages);
  } catch (error) {
  res.status(500);
- res.json({ message: error.message });
+ res.json({ message: 'ADD_LANGUAGE_ERROR' });
  }
 });
 
@@ -82,7 +82,7 @@ router.delete('/languages/:language', async (req, res) => {
  res.json(updatedLanguages);
  } catch (error) {
  res.status(500);
- res.json({ message: error.message });
+ res.json({ message: 'REMOVE_LANGUAGE_ERROR' });
  }
 });
 

diff --git a/server/tests/routes/languages.test.js b/server/tests/routes/languages.test.js
@@ -44,7 +44,7 @@ test.serial('should pass on error message', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_LANGUAGES_ERROR',
  });
 });
 
@@ -64,7 +64,7 @@ test.serial('should pass on missing language error message', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_MISSING_LANGUAGES_ERROR',
  });
 });
 
@@ -84,6 +84,6 @@ test.serial('should pass on additional language error message', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_ADDITIONAL_LANGUAGES_ERROR',
  });
 });
diff --git a/server/tests/routes/sentences.test.js b/server/tests/routes/sentences.test.js
@@ -57,7 +57,7 @@ test.serial('getting sentences should pass on error message', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_SENTENCES_ERROR',
  });
 });
 
@@ -130,7 +130,7 @@ test.serial('should pass error when getting sentences text only', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_SENTENCES_TEXT_ERROR',
  });
 });
 
@@ -151,7 +151,7 @@ test.serial('should pass error when getting approved sentences text only', async
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_APPROVED_SENTENCES_TEXT_ERROR',
  });
 });
 
@@ -172,7 +172,7 @@ test.serial('should pass error when getting undecided sentences text only', asyn
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_UNDECIDED_SENTENCES_TEXT_ERROR',
  });
 });
 
@@ -193,7 +193,7 @@ test.serial('should pass error when getting rejected sentences text only', async
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_UNDECIDED_SENTENCES_TEXT_ERROR',
  });
 });
 
@@ -214,7 +214,7 @@ test.serial('should pass error when getting list of sources', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_SENTENCES_SOURCES_ERROR',
  });
 });
 
@@ -235,7 +235,7 @@ test.serial('getting review sentences should pass on error message', async (t) =
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_SENTENCES_FOR_REVIEW_ERROR',
  });
 });
 
@@ -256,7 +256,7 @@ test.serial('getting rejected sentences should pass on error message', async (t)
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_REJECTED_SENTENCES_ERROR',
  });
 });
 
@@ -277,7 +277,7 @@ test.serial('getting my sentences should pass on error message', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_MY_SENTENCES_ERROR',
  });
 });
 
@@ -300,7 +300,7 @@ test.serial('deleting sentences should pass on error message', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'DELETE_SENTENCES_ERROR',
  });
 });
 
@@ -327,6 +327,6 @@ test.serial('adding sentences should pass on error message', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'CREATE_SENTENCES_ERROR',
  });
 });
diff --git a/server/tests/routes/stats.test.js b/server/tests/routes/stats.test.js
@@ -80,7 +80,7 @@ test.serial('should pass on error message', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_STATS_ERROR',
  });
 });
 
@@ -102,6 +102,6 @@ test.serial('should pass on error message when querying general stats', async (t
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'GET_STATS_FOR_LANGUAGE_ERROR',
  });
 });
diff --git a/server/tests/routes/users.test.js b/server/tests/routes/users.test.js
@@ -40,7 +40,7 @@ test.serial('updateSetting: should pass error', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'UPDATE_SETTINGS_ERROR',
  });
 });
 
@@ -63,7 +63,7 @@ test.serial('addLanguage: should pass error', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'ADD_LANGUAGE_ERROR',
  });
 });
 
@@ -84,6 +84,6 @@ test.serial('removeLanguage: should pass error', async (t) => {
 
  t.is(response.status, 500);
  t.deepEqual(response.body, {
- message: 'nope',
+ message: 'REMOVE_LANGUAGE_ERROR',
  });
 });