Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

API support for querying only subsets of sentences #402

Closed
ftyers opened this issue Dec 22, 2020 · 2 comments
Closed

API support for querying only subsets of sentences #402

ftyers opened this issue Dec 22, 2020 · 2 comments
Assignees
@MichaelKohler
Labels
enhancement New feature or request P2

Comments

@ftyers
Copy link
Contributor

ftyers commented Dec 22, 2020

It would be great to be able to retrieve:

  • Only approved sentences
  • Only unapproved sentences
  • All sentences (this one is already possible)
@MichaelKohler
Copy link
Member

"Only approved sentences" is possible as well, for example through: /sentence-collector/sentences/text/approved/de

However I agree that unapproved sentences only would definitely make sense as well.

@MichaelKohler MichaelKohler added enhancement New feature or request P2 labels Dec 22, 2020
MichaelKohler added a commit that referenced this issue Dec 23, 2020
@MichaelKohler
feat: add undecided/rejected text only API endpoint (fixes #402)
6d0db81
@MichaelKohler MichaelKohler self-assigned this Dec 23, 2020
MichaelKohler pushed a commit that referenced this issue Dec 23, 2020
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
8f823a4 
# [2.1.0](v2.0.27...v2.1.0) (2020-12-23)

### Bug Fixes

* add migrtion to remove not yet approved sentences for Guarani (fixes [#400](#400)) ([#406](#406)) ([9b6a08d](9b6a08d))
* change source of some Kazakh sentences as per email request ([#403](#403)) ([2d15d25](2d15d25))
* delete some bas sentences (issue [#393](#393)) ([#404](#404)) ([834b780](834b780))

### Features

* add undecided/rejected text only API endpoint (fixes [#402](#402))  ([#407](#407)) ([bc54da4](bc54da4))
* add validation function for other checks and use it for bas (fixes [#393](#393)) ([#405](#405)) ([8f66671](8f66671))
@MichaelKohler
Copy link
Member

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichaelKohler MichaelKohler

Labels
enhancement New feature or request P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelKohler @ftyers