Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Pull localizations when building and deploying #526

Closed
4 tasks done
MichaelKohler opened this issue Nov 6, 2021 · 1 comment
Closed
4 tasks done

Pull localizations when building and deploying #526

MichaelKohler opened this issue Nov 6, 2021 · 1 comment
Assignees
@MichaelKohler
Labels
enhancement New feature or request localization operations P1
Milestone
Q4 2021

Comments

@MichaelKohler
Copy link
Member

MichaelKohler commented Nov 6, 2021 •
edited
Loading

We do not need to keep the translated strings in sync with this repository. The translations will live in the Common Voice repository and for local dev the EN file is enough. However when deploying the Sentence Collector we need to pull in the translations and deploy them.

The pull script eventually will need to be called in the deployment pipeline.

  • Integrate Common Voice's locale definitions during build of the app
  • Make sure there are dummy files for local development
  • Make sure CV translated FTL files are included in the build
  • Document lang attribute should be set based on the rtl.json file
@MichaelKohler MichaelKohler self-assigned this Nov 12, 2021
@MichaelKohler MichaelKohler added this to the Q4 2021 milestone Nov 12, 2021
@MichaelKohler MichaelKohler mentioned this issue Nov 14, 2021
Closed
2 tasks
MichaelKohler pushed a commit that referenced this issue Nov 16, 2021
@semantic-release-bot
chore(release): 2.13.0
987e9df 
# [2.13.0](v2.12.5...v2.13.0) (2021-11-16)

### Bug Fixes

* add Meetei Lon language ([#541](#541)) ([78d0a17](78d0a17))

### Features

* pull localizations from CV when deploying (fixes [#526](#526)) ([#537](#537)) ([81f057a](81f057a))
@MichaelKohler
Copy link
Member Author

🎉 This issue has been resolved in version 2.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichaelKohler MichaelKohler

Labels
enhancement New feature or request localization operations P1
Projects
None yet
Milestone
Q4 2021
Development

No branches or pull requests
1 participant
@MichaelKohler