Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate workflow URL from repository URL in "retrieved from" column of workflows page #316

Merged

Conversation

obasekiosa
Copy link
Contributor

@obasekiosa obasekiosa commented Apr 12, 2021

Description

Previously the repository link in the "retrieved from" column of the workflows.html page referenced the workflow file while its text displayed the workflow repository. This change ensures both the workflow repo and the file are displayed separately.

Motivation and Context

This change prevents ambiguity for users when using the workflows page.
It shows two separate links each for the repository and workflow file.

Fixes #313: Link in the "retrieved from" column is confusing (#313)

Layout before the change:

image

Layout after the change:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@stain
Copy link
Member

stain commented Apr 13, 2021

Thanks! Would it perhaps make more sense to make the blob/master long URL be the hyperlink of the existing Path: workflows/Chip/peak.cwl string rather then adding a new line above?

@obasekiosa
Copy link
Contributor Author

Thanks! Would it perhaps make more sense to make the blob/master long URL be the hyperlink of the existing Path: workflows/Chip/peak.cwl string rather then adding a new line above?

Thanks for the feedback and suggestion.
Yes, it would.

So I looked at to code once more to confirm there is no case where for some reason the path is empty but the workflow URL exists and then by consequence the workflow URL is lost, but it seems the workflow URL is built using the path so that would never happen.

I would be pushing the changes now.

@obasekiosa
Copy link
Contributor Author

obasekiosa commented Apr 14, 2021

Based on the previous comments the new layout change is as below:

Original Layout Before Pull Request

image

Layout After Recommended Change

image

@tetron
Copy link
Member

tetron commented Apr 14, 2021

It reports 'out-of-date with the base branch" could you please merge with main or rebase on main?

@obasekiosa
Copy link
Contributor Author

It reports 'out-of-date with the base branch" could you please merge with main or rebase on main?

I have done this.

@mr-c mr-c linked an issue Apr 15, 2021 that may be closed by this pull request
@mr-c mr-c merged commit 4ce34de into common-workflow-language:main Apr 15, 2021
@mr-c
Copy link
Member

mr-c commented Apr 15, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link in the "retrieved from" column is confusing
4 participants