Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 #877

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Drop support for Python 3.8 #877

wants to merge 2 commits into from

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Oct 4, 2024

Do not merge and release until Python 3.8 has been officially declared "end-of-life" (Presumed to be October 31st or earlier, 2024).

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 99.46524% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (e174773) to head (d793d95).

Files with missing lines Patch % Lines
schema_salad/schema.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
+ Coverage   83.07%   83.11%   +0.04%     
==========================================
  Files          22       22              
  Lines        4886     4898      +12     
  Branches     1326     1325       -1     
==========================================
+ Hits         4059     4071      +12     
  Misses        548      548              
  Partials      279      279              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant