COMP: Update ctkMacroGenerateMocs to fix warnings using qt5_generate_moc #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
commented
Nov 4, 2021
lassoan
reviewed
Nov 4, 2021
…warnings This commit updates ctkMacroGenerateMocs to internally use qt5_generate_moc and fix deprecation warnings reported when building against Qt >= 5.15.0 See https://doc.qt.io/qt-5/qtcore-cmake-qt5-generate-moc.html and https://doc.qt.io/qt-5/cmake-command-reference.html#qt5-core Example of warnings: CMake Warning (dev) at /path/to/Support/Qt/5.15.2/clang_64/lib/cmake/Qt5Core/Qt5CoreMacros.cmake:44 (message): qt5_get_moc_flags is not part of the official API, and might be removed in Qt 6. Call Stack (most recent call first): /path/to/Support/Qt/5.15.2/clang_64/lib/cmake/Qt5Core/Qt5CoreMacros.cmake:86 (_qt5_warn_deprecated) /path/to/Projects/S-r/CTK/CMake/ctkMacroGenerateMocs.cmake:8 (QT5_GET_MOC_FLAGS) /path/to/Projects/S-r/CTK/CMake/ctkMacroGenerateMocs.cmake:43 (QT4_GENERATE_MOCS) Modules/Loadable/VolumeRendering/Testing/Cxx/CMakeLists.txt:41 (QT5_GENERATE_MOCS) CMake Warning (dev) at /path/to/Support/Qt/5.15.2/clang_64/lib/cmake/Qt5Core/Qt5CoreMacros.cmake:44 (message): qt5_create_moc_command is not part of the official API, and might be removed in Qt 6. Call Stack (most recent call first): /path/to/Support/Qt/5.15.2/clang_64/lib/cmake/Qt5Core/Qt5CoreMacros.cmake:120 (_qt5_warn_deprecated) /path/to/Projects/S-r/CTK/CMake/ctkMacroGenerateMocs.cmake:32 (QT5_CREATE_MOC_COMMAND) /path/to/Projects/S-r/CTK/CMake/ctkMacroGenerateMocs.cmake:43 (QT4_GENERATE_MOCS) Modules/Loadable/VolumeRendering/Testing/Cxx/CMakeLists.txt:41 (QT5_GENERATE_MOCS) This warning is for project developers. Use -Wno-dev to suppress it. Co-authored-by: Andras Lasso <[email protected]>
jcfr
force-pushed
the
fix-qt5-warnings-in-ctkMacroGenerateMocs
branch
from
a02a829
to
78d7343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prepare the transition to Qt6 by fixing warnings like the following: