BUG: Fix ctkDICOMIndexer reverting back to functor signal/slot #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
force-pushed
the
update-ctkDICOMIndexerPrivate-revert-to-functor-signal-slot
branch
from
0cf637b
to
c113bcc
Compare
jcfr
changed the title
This commit reverts 7bb0d9f (COMP: Fix Qt4/C++98 ctkDICOMIndexerPrivate build using literal signal/slot) This addresses the following error reported when running ctkDICOMIndexerTest1: QObject::connect: No such signal QThread::"finished()" QObject::connect: No such signal ctkDICOMIndexerPrivate::"startWorker()" QObject::connect: No such signal ctkDICOMIndexerPrivateWorker::"progress(int)" QObject::connect: No such signal ctkDICOMIndexerPrivateWorker::"progressDetail(QString)" QObject::connect: No such signal ctkDICOMIndexerPrivateWorker::"progressStep(QString)" QObject::connect: No such signal ctkDICOMIndexerPrivateWorker::"updatingDatabase(bool)" QObject::connect: No such signal ctkDICOMIndexerPrivateWorker::"indexingComplete(int,int,int,int)" QObject::connect: No such signal ctkDICOMIndexer::"indexingComplete(int,int,int,int)" For reference, the functor-based connection was introduced in 7f2f24a (ENH: DICOM browser rework).
jcfr
force-pushed
the
update-ctkDICOMIndexerPrivate-revert-to-functor-signal-slot
branch
from
c113bcc
to
add032c
Compare
jcfr
deleted the
update-ctkDICOMIndexerPrivate-revert-to-functor-signal-slot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts 7bb0d9f (
COMP: Fix Qt4/C++98 ctkDICOMIndexerPrivate build using literal signal/slot)This addresses the following error reported when running ctkDICOMIndexerTest1:
For reference, the functor-based connection was introduced in 7f2f24a (
ENH: DICOM browser rework)