Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Fix Qt4 build adding fallback implementation for qUtf8Printable() #909

Merged
merged 1 commit into from
Apr 21, 2020
Merged

COMP: Fix Qt4 build adding fallback implementation for qUtf8Printable() #909

merged 1 commit into from
Apr 21, 2020

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Apr 20, 2020

No description provided.

@jcfr jcfr requested a review from lassoan April 20, 2020 23:04
lassoan
lassoan approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it looks good to me.

@lassoan
Copy link
Member

lassoan commented Apr 20, 2020

You might consider adding this to ctkExport.h.in instead of creating a new header file. Or, if you add a new header file then at least include it in ctkExport.h.in (similarly to __ctkCompilerDetections_p_h) so that you don't need to manually include this new header in a bunch of files.

@jcfr
Copy link
Member Author

jcfr commented Apr 21, 2020

Thanks for the review, I applied the suggested changes and will integrate once the CI completes

@jcfr jcfr merged commit 8ec9136 into commontk:master Apr 21, 2020
@jcfr jcfr deleted the fix-qt4-build branch April 21, 2020 02:05
jcfr pushed a commit to Slicer/Slicer that referenced this pull request Apr 21, 2020
@Sunderlandkyl
ENH: Update CTK to improve ctkCheckablePushButton behavior (#4874)
9f3c61e 
List of changes:

```
$ git shortlog 27bc11d..8ec9136
Jean-Christophe Fillion-Robin (1):
      COMP: Fix Qt4 build adding fallback implementation for qUtf8Printable() (commontk/CTK#909)

Kyle Sunderland (1):
      ENH: Add checkBoxControlsButtonToggleState property to ctkCheckablePushButton (commontk/CTK#908)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassoan lassoan lassoan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfr @lassoan