Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for VTK 9.0 #936

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Adding support for VTK 9.0 #936

merged 3 commits into from
Oct 28, 2020

Conversation

kraehlit
Copy link
Contributor

Changes to support build with VTK 9.0

In VTK 9.0 QVTKOpenGLWidget is deprecated and should be replaced by QVTKOpenGLNativeWidget. Additional library references are required in VTK/Core and VTK/Widget.

Changes tested under Win10 with external build VTK 9.0.1.

Copy link
Member

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it looks good to me. I've tested it on Windows with Slicer's VTK9 master and did not see any problems.

@lassoan
Copy link
Member

lassoan commented Oct 10, 2020

@kraehlit It would be great if you could make one improvement: centralize setting of default surface format. We know that this code will have to be kept tuned as VTK and Qt is upgraded and it is Qt, VTK, and operating system dependent. Could you add a helper function that sets up default surface format and use that single line everywhere (instead of repeating a somewhat complex logic at many places)? Thank you!

@kraehlit
Copy link
Contributor Author

@lassoan I have changed the code and centralize the setting of the default surface format as you requested.

@jcfr
Copy link
Member

jcfr commented Oct 28, 2020

Thanks. I will integrate shortly 🙏

@jcfr jcfr merged commit 7952569 into commontk:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants