This repository has been archived by the owner on Feb 26, 2023. It is now read-only.
specify stricter constraint for libc version #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sass-sys specifies a constraint of "0.1", but sass-rs specifies "0", which allows version 0.2 and above this shouldn't be a problem, because a "0.1" version would satisfy both constraints, but I think the reason this isn't working is because of rust-lang/cargo#2064 which might not get resolved anytime soon without this fix, building sass-rs fails because it tries to use libc 0.2 which has a different interface from the 0.1 that sass-sys used this gets things building again for now, but we should look into updating to the 0.2 interface when we get a chance
|
@blaenk thx for the pull request :-) We should probably upgrade to libc 0.2. I am also ok removing Cargo.lock, I guess we can leave that for the application. |
|
@blaenk I've upgraded both sass-sys and sass-rs to libc 0.2, let me know of any problems. |
|
will do 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sass-sys specifies a constraint of "0.1", but sass-rs specifies "0",
which allows version 0.2 and above
this shouldn't be a problem, because a "0.1" version would satisfy both
constraints, but I think the reason this isn't working is because of
rust-lang/cargo#2064 which might not get resolved anytime soon
without this fix, building sass-rs fails because it tries to use
libc 0.2 which has a different interface from the 0.1 that sass-sys used
this gets things building again for now, but we should look into
updating to the 0.2 interface when we get a chance
By the way, I don't think we should version Cargo.lock