Add newer versions of EASTL and update install script. #1403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's 2 "interesting" things in this change (aside from the boring "just add new versions" part):
recursive: false
: EASTL suffered from a cyclical submodule dependency fiasco (see Circular submodule dependency causes recursive clones or submodule updates to fail electronicarts/EASTL#301), I actually don't know how this worked before. When I tried to doce_install install eastl
locally I'd hit the infinite recursion issue, this no longer occurs if we opt out of a recursive clone.after_stage_script
: starting in version3.21.23
EASTL moved away from submodule dependencies to potentially fix the circular dependency fiasco (see electronicarts/EASTL@c530255) and replaced them with CMake's FetchContent functionality. This script is an attempt to pull out the only non-test dependency (EABase) and put it in EASTL's include path so the parts of EASTL which do#include <EABase/foo.h>
still work.Tested running
ce_install install eastl
in a local instance of CE and things work as expected with all versions.The corresponding change in
compiler-explorer
is compiler-explorer/compiler-explorer#6816