Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix compose schema" #630

Merged
merged 1 commit into from
May 16, 2024
Merged

Revert "Fix compose schema" #630

merged 1 commit into from
May 16, 2024

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented May 16, 2024

Reverts #625

see compose-spec/compose-spec#501

#625 adds a bunch of regexp to validate formats. We also have to support variable being used as values for interpolation, so can't add such a validation in the spec

@ndeloof ndeloof requested review from glours, milas and jhrotko May 16, 2024 11:32
This reverts commit 25fe179.

Signed-off-by: Nicolas De Loof <[email protected]>
@ndeloof ndeloof force-pushed the revert-625-fix-compose-schema branch from e5cb4ba to 67a7b9f Compare May 16, 2024 12:52
@ndeloof ndeloof enabled auto-merge (rebase) May 16, 2024 12:52
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 3b30ce3 into main May 16, 2024
15 checks passed
@ndeloof ndeloof deleted the revert-625-fix-compose-schema branch May 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants