Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-c v0.9.31 #10

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Mar 22, 2024

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https:/regro/cf-scripts/actions/runs/8388296342, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@carterbox
Copy link
Member

carterbox commented Mar 22, 2024

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=901036&view=logs&j=a70f640f-cc53-5cd3-6cdc-236a1aa90802&t=6119ccbe-9301-594f-7c27-f792b80a7fcc&l=1631

ERROR (cargo-c,Library/bin/cargo-cbuild.exe): $RPATH/git2.dll not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?

Linking to git is a new one for me. I didn't even know git offered an API.

@carterbox
Copy link
Member

carterbox commented Mar 22, 2024

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=901036&view=logs&j=8c139a40-380b-5518-bf6b-edcb18cbf319&t=e71f8d0d-13be-528e-b5e7-bfc20e0db699&l=1466

cc1: error: bad value 'power8' for '-mtune=' switch
  cc1: note: valid arguments to '-mtune=' switch are: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake-client rocketlake icelake-server cascadelake tigerlake cooperlake sapphirerapids alderlake bonnell atom silvermont slm goldmont goldmont-plus tremont knl knm intel x86-64 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 znver2 znver3 znver4 btver1 btver2 generic native

This flag comes from CFLAGS set by our channel?

@hmaarrfk
Copy link
Contributor

This flag comes from CFLAGS set by our channel?

I've seen many flags confuse host and build in rust projects, and not consider PPC64LE at all.

It might be a bug upstream in a recent change?

@hmaarrfk
Copy link
Contributor

Seems like (some?) of the failures aren't specific to this new version of cargo-c

@carterbox
Copy link
Member

The wrong compiler is being used for the linux cross-compile.

error occurred: Command "/home/conda/feedstock_root/build_artifacts/cargo-c_1711101284970/_build_env/bin/x86_64-conda-linux-gnu-cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-mcpu=power8" "-mtune=power8" "-ftree-vectorize" "-fPIC" "-fstack-protector-strong" "-fno-plt" "-O3" "-pipe" "-isystem" "/home/conda/feedstock_root/build_artifacts/cargo-c_1711101284970/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include" "-fdebug-prefix-map=/home/conda/feedstock_root/build_artifacts/cargo-c_1711101284970/work=/usr/local/src/conda/cargo-c-0.9.31" "-fdebug-prefix-map=/home/conda/feedstock_root/build_artifacts/cargo-c_1711101284970/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla=/usr/local/src/conda-prefix" "-I" "src/zlib" "-fvisibility=hidden" "-DZ_SOLO" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/home/conda/feedstock_root/build_artifacts/cargo-c_1711101284970/work/target/release/build/libz-sys-036b54880f582bf4/out/lib/0dc752f03a07a721-zutil.o" "-c" "src/zlib/zutil.c" with args "x86_64-conda-linux-gnu-cc" did not execute successfully (status code exit status: 1).

The logs show that x86_64-conda-linux-gnu-cc is being used, but powerpc64le-conda-linux-gnu-cc is the compiler that should be used because the target it powerpc.

@carterbox
Copy link
Member

I can replicate this error locally:

(test) bash-5.1$ x86_64-conda-linux-gnu-cc $CFLAGS test.c
cc1: error: bad value 'power8' for '-mtune=' switch
cc1: note: valid arguments to '-mtune=' switch are: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake-client rocketlake icelake-server cascadelake tigerlake cooperlake sapphirerapids alderlake bonnell atom silvermont slm goldmont goldmont-plus tremont knl knm intel x86-64 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 znver2 znver3 znver4 btver1 btver2 generic native
(test) bash-5.1$ powerpc64le-conda-linux-gnu-cc $CFLAGS test.c

@carterbox
Copy link
Member

Need to investigate why $CC isn't being used. It is set to the correct compiler.

@carterbox
Copy link
Member

Possibly, this package now depends on https:/conda-forge/libgit2-feedstock

@carterbox
Copy link
Member

carterbox commented Mar 28, 2024

The remaining issue with PowerPC is because libz-sys revends libz, but doesn't use the correct compiler when cross-building libz. You cannot disable revending of libz, so we will need to track down the bug which causes libz-sys to use the x86 compiler instead of the cross-compiler or build emulated/native.

Copy link
Member

@carterbox carterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the build passes, I'm good with this. However, it does increase the minimum GLIBC version that is required.

@regro-cf-autotick-bot regro-cf-autotick-bot mentioned this pull request May 4, 2024
3 tasks
@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 5, 2024

@conda-forge-admin please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • You're setting a requirement on sysroot_linux- directly; this should now be done by adding a build dependence on {{ stdlib("c") }}, and overriding c_stdlib_version in recipe/conda_build_config.yaml for the respective platform as necessary. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/meta.yaml Outdated Show resolved Hide resolved
@@ -22,6 +23,7 @@ requirements:
- zlib # [not win]
host:
- libcurl # [not win]
- libgit2 >=1.7.2,<1.8.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this here? is it not compatible with 1.8.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https:/rust-lang/git2-rs/pull/1032/files

it seems it just isn't compatible yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truthfully, for me this is the larger issue given that libgit2 has already moved to 1.8 conda-forge wide and this might cause some conflicts.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 5, 2024

@conda-forge-admin please rerender

@regro-cf-autotick-bot regro-cf-autotick-bot mentioned this pull request Jun 18, 2024
3 tasks
@regro-cf-autotick-bot regro-cf-autotick-bot mentioned this pull request Jun 27, 2024
3 tasks
@carterbox carterbox added the wontfix This will not be worked on label Jun 27, 2024
@carterbox carterbox closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants