Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use powershell + WScript #647

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

jaimergp
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #641

@hmaarrfk
Copy link
Contributor

Do we want to revert the "brownout code" as well? I feel like this is a "minor issue" and I would rather reduce churn since GUI users can press "ignore" on the error and move on.

@hmaarrfk
Copy link
Contributor

did you need somebody to test this?

@jaimergp
Copy link
Member Author

I tested the script locally by calling it directly and did get my popup and warning. I did not build an installer locally though. I think the brownout code is correct, isn't it? I can test it locally tomorrow.

@hmaarrfk
Copy link
Contributor

I tested the script locally by calling it directly and did get my popup and warning. I did not build an installer locally though. I think the brownout code is correct, isn't it? I can test it locally tomorrow.

Its more about "do we want a versionned installer for windows without the brownout but with the warning".

My inclination is to say that isn't that valuable.

@jaimergp
Copy link
Member Author

Ah, I see. Yea, I don't think it's too valuable. If someone complains, well, the Miniforge versions do work perfectly and that's where we want to direct people to.

@hmaarrfk hmaarrfk merged commit de8fc9f into conda-forge:main Sep 22, 2024
24 checks passed
@hmaarrfk
Copy link
Contributor

Ok thank you, pre-release started:
https:/conda-forge/miniforge/releases/tag/24.7.1-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Install 24.7.1(x64) on windows10/11 encounter: Failed to run pre_install
2 participants