pip 18.1 seems to contact pypi in the cleanup phase

[hmaarrfk]

Issue:
It seems that pip 18.1 is trying to contact pypi in the cleaning up phase of building a recipe
See
https://travis-ci.org/conda-forge/celiagg-feedstock/jobs/438435703#L758
https://circleci.com/gh/conda-forge/celiagg-feedstock/79?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Builds of:
conda-forge/celiagg-feedstock#4

And you can trust that it happens on windows too, a snippet from my local machine:

Cleaning up...
Removed build tracker 'C:\\Users\\mark\\AppData\\Local\\Temp\\pip-req-tracker-mjcpd6gi'
Config variable 'Py_DEBUG' is unset, Python ABI tag may be incorrect
Config variable 'WITH_PYMALLOC' is unset, Python ABI tag may be incorrect
1 location(s) to search for versions of pip:
* https://pypi.org/simple/pip/
Getting page https://pypi.org/simple/pip/
Starting new HTTPS connection (1): pypi.org:443
https://pypi.org:443 "GET /simple/pip/ HTTP/1.1" 200 10163
Analyzing links from page https://pypi.org/simple/pip/
  Found link https://files.pythonhosted.org/packages/3d/9d/1e313763bdfb6a48977b65829c6ce2a43eaae29ea2f907c8bbef024a7219/pip-0.2.tar.gz#sha256=88bb8d029e1bf4acd0e04d300104b7440086f94cc1ce1c5c3c31e3293aee1f81 (from https://pypi.org/simple/pip/), version: 0.

The following NEW packages will be INSTALLED:

    blas:           1.1-openblas                        conda-forge
    celiagg:        1.0.3-py36h0f91c3a_0                local
    certifi:        2018.8.24-py36_1001                 conda-forge
    freetype:       2.9.1-he8b6a0d_1004                 conda-forge
    libflang:       5.0.0-vc14_20180208                 conda-forge [vc14         ]
    libpng:         1.6.34-vc14_0                       conda-forge [vc14         ]
    llvm-meta:      5.0.0-0                             conda-forge
    numpy:          1.15.2-py36_blas_openblash8d851b4_1 conda-forge [blas_openblas]
    openblas:       0.2.20-vc14_8                       conda-forge [vc14         ]
    openmp:         5.0.0-vc14_1                        conda-forge [vc14         ]
    pip:            18.1-py36_1000                      conda-forge
    python:         3.6.6-he025d50_0                    conda-forge
    setuptools:     40.4.3-py36_0                       conda-forge
    vc:             14-0                                conda-forge
    vs2015_runtime: 14.0.25420-0                        conda-forge
    wheel:          0.32.1-py36_0                       conda-forge
    wincertstore:   0.2-py36_1002                       conda-forge
    zlib:           1.2.11-vc14_0                       conda-forge [vc14         ]

>conda info

     active environment : base
    active env location : C:\Users\mark\Miniconda3
            shell level : 1
       user config file : C:\Users\mark\.condarc
 populated config files : C:\Users\mark\.condarc
          conda version : 4.5.11
    conda-build version : 3.16.0
         python version : 3.6.6.final.0
       base environment : C:\Users\mark\Miniconda3  (writable)
           channel URLs : https://conda.anaconda.org/ramonaoptics/win-64
                          https://conda.anaconda.org/ramonaoptics/noarch
                          https://conda.anaconda.org/mark.harfouche/win-64
                          https://conda.anaconda.org/mark.harfouche/noarch
                          https://conda.anaconda.org/conda-forge/win-64
                          https://conda.anaconda.org/conda-forge/noarch
                          https://repo.anaconda.com/pkgs/main/win-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/free/win-64
                          https://repo.anaconda.com/pkgs/free/noarch
                          https://repo.anaconda.com/pkgs/r/win-64
                          https://repo.anaconda.com/pkgs/r/noarch
                          https://repo.anaconda.com/pkgs/pro/win-64
                          https://repo.anaconda.com/pkgs/pro/noarch
                          https://repo.anaconda.com/pkgs/msys2/win-64
                          https://repo.anaconda.com/pkgs/msys2/noarch
          package cache : C:\Users\mark\Miniconda3\pkgs
                          C:\Users\mark\AppData\Local\conda\conda\pkgs
       envs directories : C:\Users\mark\Miniconda3\envs
                          C:\Users\mark\AppData\Local\conda\conda\envs
                          C:\Users\mark\.conda\envs
               platform : win-64
             user-agent : conda/4.5.11 requests/2.18.4 CPython/3.6.6 Windows/10 Windows/10.0.17134
          administrator : False
             netrc file : None
           offline mode : False

[jjhelmus]

Does this occur if you include --disable-pip-version-check in the pip install command?

[jjhelmus]

The pip maintainers have indicated that it would be appropriate for the conda package to modify pip to not show the out of date message, pypa/pip#5346. For pip 18.0 and 18.1 it looks as if modifying the contents of the INSTALLER file would be sufficient to suppress the upgrade message, pypa/pip#5368. I believe that even with a modified INSTALLER file pip would still query PyPI for a remote version.

[hmaarrfk]

script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv --disable-pip-version-check"
seems to suppress the checks.

Maybe we should just have a {{ PIP_INSTALL_FLAGS }} environment variable.

[hmaarrfk]

Just adding this for reference: Transcript of conversation on gitter

@isuruf
Is that a problem though? pip contacts pypi to display that warning about pip being out of date
Mark Harfouche
@hmaarrfk
23:28
not too sure, I just thought that the build process was supposed to b e locked out of pypi.org
Jonathan J. Helmus
@jjhelmus
23:51
setuptools is patched to not download from PyPI, https:/conda-forge/setuptools-feedstock/blob/master/recipe/0002-disable-downloads-inside-conda-build.patch
for most install operations pip calls out to setuptools, but it will query pypi for some version information, most notably to query for new versions of pip

[ocefpaf]

I believe it is safe to close this one now. Please re-open if I'm mistaken.

[hmaarrfk]

yeah, i just wish we would include a patch to make --disable-version-check by default. ;) that annoying spewing output is so distracting....