Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip v10.0.0 #10

Closed

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR was created by the cf-regro-autotick-bot.

The cf-regro-autotick-bot is a service to automatically track the dependency graph and propose package version updates for conda-forge. It is very likely that the current package version for this feedstock is out of date.

Notes and instructions for merging this PR:

  1. Please check that the dependencies have not changed.
  2. Please merge the PR only after the tests have passed.
  3. Feel free to push to the bot's branch to update this PR if needed.
  4. The bot will almost always only open one PR per version.

Finally, feel free to drop us a line if there are any issues!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

jakirkham commented Apr 15, 2018

We will need to tread carefully here as we need to document disabling build isolation generally. Alternatively we could teach pip to do that for us when using conda-build.

cc @conda-forge/core

xref: pypa/pip#5033
xref: pypa/pip#5053
xref: conda/conda-build#2748
xref: pypa/pip#5060

@jjhelmus
Copy link
Contributor

For reference, --no-build-isolation is needed to disable build isolation in pip 10. I took a while but I finally ran into a case where this was needed, conda-forge/dask-ml-feedstock#6.

@isuruf
Copy link
Member

isuruf commented Jun 20, 2018

How about adding a activate script that exports PIP_NO_BUILD_ISOLATION=True when CONDA_BUILD is set?

@msarahan
Copy link
Member

Seems to me that conda-build should set PIP_NO_BUILD_ISOLATION=True anyway

@isuruf
Copy link
Member

isuruf commented Jun 20, 2018

Btw, I'm not sure if the option is PIP_NO_BUILD_ISOLATION=True or PIP_BUILD_ISOLATION=False

@jakirkham
Copy link
Member

There are a bunch of options discussed in issue ( conda/conda-build#2748 ) for generally handling pip flags in a nicer way.

Should add we might want to skip to 10.0.1 if we are doing this. ( #11 )

@jjhelmus
Copy link
Contributor

pypa/pip#5229 seems to indicate that the variable should be PIP_NO_BUILD_ISOLATION=false.

@jjhelmus
Copy link
Contributor

I tested a recipe that requires build isolation and can confirm that PIP_NO_BUILD_ISOLATION=False is the correct setting to DISABLE build isolation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants