Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pxd in (a) distribution? #70

Closed
bollwyvl opened this issue Jan 3, 2020 · 1 comment
Closed

Include pxd in (a) distribution? #70

bollwyvl opened this issue Jan 3, 2020 · 1 comment

Comments

@bollwyvl
Copy link

bollwyvl commented Jan 3, 2020

I'm looking into packaging neuralcoref, which does a cythonized build against the spacy pxd files.

I've gotten an approach working, where before python -m pip install . in neuralcoref, I sneakily copy all the pxd from the spacy github tarball into the installed spacy (if they aren't already there) do my build, and then clean them up... but that seems pretty gross.

I guess I'm wondering which of the following approaches would be the most robust/least work for everybody:

  • layer in the pxd from the source tarball as another source during build of spacy (so neuralcoref only depends on spacy in host and run)
  • still grab the source tarball, but add another output here, spacy-cython-source, which neuralcoref can depend on in host, while just depending on spacy in run
  • try to get spacy itself to distribute pxd in its source tarball

Thoughts?

@bollwyvl
Copy link
Author

Closed by explosion/spaCy#4868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant