Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-release updates #43

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Pre-release updates #43

merged 8 commits into from
Mar 12, 2024

Conversation

trallard
Copy link
Collaborator

Description

This PR makes some updates needed to make a release

This pull request:

  • Adds the private key to package.json needed after the addition of workspaces in Add support for JupyterLab 4.x #34
  • Bumps conda-store-ui version
  • Bumps this package version
  • Updates RELEASE.md to match the release checklist

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

How to test

pavithraes
pavithraes approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@pavithraes pavithraes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to re-run the linter (see CI failures), but looks good otherwise. Thank you!

krassowski
krassowski suggested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failure is due to lock file being out of sync with dependencies, not due to lint failure. The lock file will need fixing.

@krassowski krassowski mentioned this pull request Mar 12, 2024
Merged
3 tasks
@trallard
Merge pull request #44 from krassowski/fix-yarn-lock-file
d15e783 
Fix lockfile, fix .yarnrc.yml setting
krassowski
krassowski reviewed Mar 12, 2024
View reviewed changes
RELEASE.md Outdated Show resolved Hide resolved
@krassowski krassowski mentioned this pull request Mar 12, 2024
Closed
3 tasks
@krassowski krassowski mentioned this pull request Mar 12, 2024
Merged
3 tasks
@krassowski
Copy link
Contributor

The remaining issue is due to a bug in the latest @types/react which come from updated conda-store-ui version: DefinitelyTyped/DefinitelyTyped#66841. I opened #46 with a fix.

@trallard
Merge pull request #46 from krassowski/fix-build
a2c6082 
Pin `@types/react` to a working version, deduplicate lock file
krassowski
krassowski approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trallard trallard merged commit 918c363 into main Mar 12, 2024
6 checks passed
@trallard trallard deleted the pre-release-prep branch March 12, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

@pavithraes pavithraes pavithraes approved these changes

Assignees
No one assigned
Labels
block-release ⛔️ type: maintenance 🛠
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trallard @krassowski @pavithraes