Adding initial support for GCP #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beraldoleal
force-pushed
the
gcp-without-gke
branch
2 times, most recently
from
c242956
to
12998c5
Compare
beraldoleal
force-pushed
the
gcp-without-gke
branch
3 times, most recently
from
e28605f
to
d7578e6
Compare
|
Hi @beraldoleal ! I've already started my review but I'd like to send a few words before making comments in code:
|
wainersm
reviewed
Jul 18, 2024
wainersm
reviewed
Jul 19, 2024
wainersm
reviewed
Jul 19, 2024
wainersm
reviewed
Jul 19, 2024
wainersm
reviewed
Jul 19, 2024
wainersm
reviewed
Jul 19, 2024
wainersm
reviewed
Jul 19, 2024
wainersm
reviewed
Jul 19, 2024
wainersm
reviewed
Jul 19, 2024
wainersm
reviewed
Jul 19, 2024
beraldoleal
force-pushed
the
gcp-without-gke
branch
from
0b3f038
to
3dfbab1
Compare
|
Hi @wainersm, thanks for your review! Really appreciated! Let me know if you are ok with the open threads, and even the closed ones, please feel free to reopen. About the account, I will send you on slack the credentials to a GCP cluster, if you still need. |
beraldoleal
force-pushed
the
gcp-without-gke
branch
2 times, most recently
from
3960a06
to
f2c7c23
Compare
wainersm
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Hi @beraldoleal !
I see that you followed the instructions in https:/confidential-containers/cloud-api-adaptor/blob/main/src/cloud-api-adaptor/docs/addnewprovider.md which makes me more comfortable to review.
All the comments I made you addressed and/or will on following changes. Unfortunately I don't have GCP account to give it a try but I know that you tested it, so we are fine.
thanks!
bpradipt
reviewed
Aug 19, 2024
bpradipt
reviewed
Aug 19, 2024
bpradipt
reviewed
Aug 19, 2024
This is basically Cfir's work with some modifications to support the repository layout and small fixes. Signed-off-by: Cfir Cohen <[email protected]> Signed-off-by: Beraldo Leal <[email protected]>
mkosi uses userdata, necessary here if we are going to avoid packer. Signed-off-by: Beraldo Leal <[email protected]>
beraldoleal
force-pushed
the
gcp-without-gke
branch
from
f2c7c23
to
15e89fb
Compare
bpradipt
reviewed
Aug 20, 2024
bpradipt
reviewed
Aug 20, 2024
Some basic instructions on how to test and deploy GCP. Signed-off-by: Cfir Cohen <[email protected]> Signed-off-by: Beraldo Leal <[email protected]>
beraldoleal
force-pushed
the
gcp-without-gke
branch
from
15e89fb
to
3f884a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically Cfir' work with me changing paths and small things, to accommodate repository layout changes a few months ago.
We had this on hold because I was working on GKE support as well. However, GKE right now depends on #1920. So my proposal is to merge this, since it will not affect other providers, and when #1920 is merged I will send another PR with the GKE support.