Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBMCloud-Powervs docs and pre-req update #1942

Merged

Conversation

Vaibhav-Nazare
Copy link
Contributor

Changes:

  1. Moving from centos 8-stream to centos 9-stream for qcow2ova image.
  2. Adding additional steps to setup a DHCP server
  3. Updating pre-req.sh for installing additional packages protobuf-compiler and device-mapper-devel

@Vaibhav-Nazare Vaibhav-Nazare force-pushed the ibmcloud-powervs-updates branch 2 times, most recently from 81a093c to 397d5fc Compare July 29, 2024 07:00
@stevenhorsman
Copy link
Member

The commit message check is failing as the body with an explanation of the changes is missing.

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I wasn't clear, but I would expect the DCO signoff to be after the commit body e.g.

ibmcloud-powervs: Revise ibmcloud-powervs README

This updates the basic setup requirements needed to run cloud-api-adaptor using ibmcloud-powervs

Signed-off-by: Vaibhav-Nazare <[email protected]>

instead of

ibmcloud-powervs: Revise ibmcloud-powervs README
Signed-off-by: Vaibhav-Nazare <[email protected]>

This updates the basic setup requirements needed to run cloud-api-adaptor using ibmcloud-powervs

@Vaibhav-Nazare Vaibhav-Nazare force-pushed the ibmcloud-powervs-updates branch 2 times, most recently from 5af1e79 to 49efdf6 Compare August 13, 2024 09:15
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @Vaibhav-Nazare!

This updates the basic setup requirements needed to run cloud-api-adaptor using ibmcloud-powervs

Signed-off-by: Vaibhav-Nazare <[email protected]>
Install additional packages like protobuf-compiler and device-mapper-devel as move from centos/8-stream to centos/9-stream

Signed-off-by: Vaibhav-Nazare <[email protected]>
@Vaibhav-Nazare Vaibhav-Nazare deleted the ibmcloud-powervs-updates branch August 26, 2024 06:34
@Vaibhav-Nazare Vaibhav-Nazare restored the ibmcloud-powervs-updates branch August 26, 2024 06:35
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bpradipt bpradipt merged commit 81485e1 into confidential-containers:main Sep 6, 2024
20 checks passed
@Vaibhav-Nazare Vaibhav-Nazare deleted the ibmcloud-powervs-updates branch September 23, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants