docs: redirect users to use make targets on builds #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beraldoleal
force-pushed
the
build-docs-fix
branch
from
ce7fbc9
to
995f637
Compare
wainersm
reviewed
Aug 9, 2024
wainersm
reviewed
Aug 9, 2024
beraldoleal
force-pushed
the
build-docs-fix
branch
from
995f637
to
0b7eded
Compare
|
@wainersm thanks for your comment, I fixed the main one with a force-push. let me know if you are ok with it now. |
|
@wainersm @beraldoleal - FYI I'm think of doing the same change as this for the podvm_builder as well (to redirect people to use the |
Current dockerfiles are not ready to build directly from the folder. Builder is broken as also depends on .git and .hack folders. Make targets are working, so lets redirect our readers to use those targets. We can improve the targets as needed and this will be transparant for the readers. Signed-off-by: Beraldo Leal <[email protected]>
beraldoleal
force-pushed
the
build-docs-fix
branch
from
0b7eded
to
b8df264
Compare
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Aug 15, 2024
Similar to confidential-containers#1990, update the podvm_builder documentation to use the `make` command, rather than the docker file directly to hide the complexity and allow the versions to be picked up automatically Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Aug 27, 2024
Similar to confidential-containers#1990, update the podvm_builder documentation to use the `make` command, rather than the docker file directly to hide the complexity and allow the versions to be picked up automatically Signed-off-by: stevenhorsman <[email protected]>
|
@stevenhorsman @beraldoleal can we merge this ? |
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Sep 5, 2024
Similar to confidential-containers#1990, update the podvm_builder documentation to use the `make` command, rather than the docker file directly to hide the complexity and allow the versions to be picked up automatically Signed-off-by: stevenhorsman <[email protected]>
Yeah, I happy with that. |
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Sep 10, 2024
Similar to confidential-containers#1990, update the podvm_builder documentation to use the `make` command, rather than the docker file directly to hide the complexity and allow the versions to be picked up automatically Signed-off-by: stevenhorsman <[email protected]>
wainersm
pushed a commit
that referenced
this pull request
Sep 10, 2024
Similar to #1990, update the podvm_builder documentation to use the `make` command, rather than the docker file directly to hide the complexity and allow the versions to be picked up automatically Signed-off-by: stevenhorsman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current dockerfiles are not ready to build directly from the folder. Builder is broken as also depends on .git and .hack folders. Make targets are working, so lets redirect our readers to use those targets.
We can improve the targets as needed and this will be transparant for the readers.