-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
Updates the hmac version requirements and code to fix the build errors Fixes: #16 Signed-off-by: stevenhorsman <[email protected]>
Hey @arronwy - this issue is causing problems in the kata-agent CCv0 build due to the dependency on this repo for the |
H @sameo - it looks like you might also have access to this repo, so if you are available to take a look that would be helpful. Thanks! |
Hey @stevenhorsman . Thanks for the PR...Running the GH actions now, let's see. |
- Fix nightly clippy linting errors Signed-off-by: stevenhorsman <[email protected]>
@sameo - thanks for kicking off the workflow. There were a bunch of nightly clippy errors. None of it in code I changed, but I've fixed up most of them. There was one error in |
Hi @arronwy - are you able to help with the final linting problem? Thanks. |
Sure, I'll be back to office tomorrow and check this issue with @pravinrajr9 |
utils/keyprovider.rs is auto generated code, there is a issue opened here hyperium/tonic#876 has an open issue
|
@pravinrajr9 - thanks for the information and link. Given that the tonic issue hasn't been looked at for 12 days and this PR has been holding up work in kata-containers for 8 days it would be great to get a workaround in with the patch you suggested. |
@sameo Since the clippy error happens on nightly build aganist auto generated code, can we merged this PR first and wait tonic upstream to fix the issue to avoid the temp fix in our repo? |
@arronwy I'd prefer if we carry @pravinrajr9 patch and disable the autogenerated code until hyperium/tonic#892 is merged. |
We need 0.10+ or else we hit that error: error[E0277]: the trait bound `sha2::Sha256: CoreProxy` is not satisfied --> src/blockcipher/aes_ctr.rs:25:22 | 25 | pub hmac: Option<HmacSha256>, | ^^^^^^^^^^ the trait `CoreProxy` is not implemented for `sha2::Sha256` | = note: required because of the requirements on the impl of `BlockSizeUser` for `HmacCore<sha2::Sha256>` For more information about this error, try `rustc --explain E0277`. error: could not compile `ocicrypt-rs` due to previous error Signed-off-by: Samuel Ortiz <[email protected]>
Do not autogenerate keyprovider.rs and patch it until hyperium/tonic#892 is merged Signed-off-by: Samuel Ortiz <[email protected]>
@arronwy @stevenhorsman @pravinrajr9 Build is fixed with a couple of fixes. Are you ok with merging it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @stevenhorsman @sameo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updates the hmac version requirements and code to fix the build errors
Fixes: confidential-containers/guest-components#263
Signed-off-by: stevenhorsman [email protected]