Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NJsonSchema to v11 #2185

Closed
wants to merge 2 commits into from
Closed

Update NJsonSchema to v11 #2185

wants to merge 2 commits into from

Conversation

NoahStolk
Copy link
Contributor

@NoahStolk NoahStolk commented Feb 5, 2024 •
edited
Loading

Superseded by: #2263

A few notes:

  • This is a breaking change, and should be included in a major version release only, as we're dropping support for NJsonSchema v10. This change will impact users that manage their own references to NJsonSchema v10.
  • Newtonsoft.Json-based generators have been moved to a separate NuGet package, so the reference to NJsonSchema has been replaced with a reference to NJsonSchema.NewtonsoftJson. See NSwag 14 announcement and NJsonSchema v11 release notes.
  • EnumHandling no longer exists, so the WithJsonSchemaGeneratorSettingsSerDe unit test has been updated to use JsonSerializerSettings instead.

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Feb 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@NoahStolk NoahStolk marked this pull request as ready for review February 14, 2024 13:52
@NoahStolk NoahStolk requested a review from a team as a code owner June 24, 2024 11:56
@NoahStolk NoahStolk marked this pull request as draft July 16, 2024 08:02
@NoahStolk
Copy link
Contributor Author

For some reason the PR is stuck on "Processing updates"... Will close and re-open to see if that helps.

@NoahStolk NoahStolk closed this Jul 16, 2024
@NoahStolk
Copy link
Contributor Author

image

I can't re-open it. I think the PR broke because the fork source was changed to https:/ah-/confluent-kafka-dotnet for some reason...

@NoahStolk NoahStolk mentioned this pull request Jul 16, 2024
Merged
@NoahStolk
Copy link
Contributor Author

I've opened a new PR: #2263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KB-RBullock KB-RBullock KB-RBullock approved these changes

Assignees
No one assigned
Labels
schema registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoahStolk @KB-RBullock @rayokota