Fix Node.js v16 error responses on HTTP1.1 #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <[email protected]>
srikrsna-buf
approved these changes
Sep 3, 2024
timostamm
deleted the
tstamm/Fix-Node.js-v16-error-responses-on-HTTP1.1
branch
This was referenced Sep 5, 2024
Merged
timostamm
added a commit
that referenced
this pull request
Sep 12, 2024
See #1206 Signed-off-by: Timo Stamm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug for Connect-ES servers running on Node.js v16: When an error occurred when parsing the request body, the server would silently fail to write the error to the response.
For technical reasons, we haven't been running the Connect Conformance tests on Node.js v16, and this bug went unnoticed. Now that we're more flexible with running tests on different versions of Node.js (thanks to #1194), we can add v16 to CI to make sure we don't regress.