-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestReadRotatedLog fails on windows #3554
Labels
kind/unconfirmed-bug-claim
Unconfirmed bug claim
Comments
it seems like the file is not closed correctly or cri is playing with the file, I think we can lock the file before processing the renaming operation |
@fahedouch would you claim dibs on this? Pretty sure a fix on this would significantly improve windows logs stability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Steps to reproduce the issue
Run unit tests for windows.
Describe the results you received and expected
This does not seem like a non-compatible test, but rather an actual issue?
I'll skip the test for the time being so that we can enable unit tests for windows, but this should be looked into?
What version of nerdctl are you using?
main
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response
The text was updated successfully, but these errors were encountered: