Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go version associated with containerd release in CI #166

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

jsturtevant
Copy link
Contributor

@jsturtevant jsturtevant commented Aug 3, 2023

This ensures that there isn't failures with testing when go version doesn't match the release as experienced in #147.

this also bumps the containerd versions to latest patches

fixes #147

@jsturtevant jsturtevant force-pushed the use-containerd-release-binary branch 13 times, most recently from 6e1323f to 8e3e30f Compare August 4, 2023 00:28
@jsturtevant
Copy link
Contributor Author

jsturtevant commented Aug 4, 2023

When looking into this I found that since we need to build the tests from source anyways, we could just use the go version from the source.

Got it working but some tests are skipped (go test -test.skip) in CI (#122) using a flag that is only supported in golang 1.20 so CI isn't passing.

a couple options to unblock are:

  • we could download the binaries and just use go 1.20 for the test suite
  • look into the test failures.

Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsturtevant
Copy link
Contributor Author

unfortunately CI isn't passing do the skipped tests so will need to fix those or only use golang 1.20+ for the tests

@github-actions github-actions bot added the T-CI Changes in project's CI label Aug 18, 2023
@jsturtevant jsturtevant force-pushed the use-containerd-release-binary branch 7 times, most recently from dbbb381 to ae67593 Compare August 19, 2023 00:23
@jsturtevant
Copy link
Contributor Author

@Mossaka @mxpv this is ready for review, It also includes the temp fix for CI failing. Alternatively I also put the temp fix in #179

- name: Checkout containerd
uses: actions/checkout@v3
with:
repository: containerd/containerd
path: src/github.com/containerd/containerd
ref: ${{ matrix.containerd }}

- name: Get Go Version
run: |
go_version=$(awk -F': ' '/GO_VERSION/ {gsub(/["'\'']/, "", $2); print $2; exit}' .github/workflows/release.yml)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have .github/workflows/release.yml, right?

❯ cat .github/workflows/release.yml
cat: .github/workflows/release.yml: No such file or directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the containerd release file since it is the containerd repository we checked out in the step before

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, right right.

@mxpv
Copy link
Member

mxpv commented Aug 21, 2023

Could you also squash the commit history?

This ensures that there isn't flakes with testing when go version doesn't match the release as experienced in containerd#147

Signed-off-by: James Sturtevant <[email protected]>
@mxpv mxpv merged commit a5a29fc into containerd:main Aug 21, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-CI Changes in project's CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly CI is failing integration tests
3 participants