host-local: remove redundant startRange in RangeIterator to avoid mismatching with startIP #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @squeed |
squeed
reviewed
Feb 24, 2021
| @@ -215,6 +215,7 @@ func (i *RangeIter) Next() (*net.IPNet, net.IP) { | |||
|
|
|||
| if i.startIP == nil { | |||
| i.startIP = i.cur | |||
| i.startRange = i.rangeIdx | |||
| } else if i.rangeIdx == i.startRange && i.cur.Equal(i.startIP) { | |||
There was a problem hiding this comment.
Now that I look at this, do we even need startRange? Since we validate that ranges can't overlap, that should be sufficient, right?
There was a problem hiding this comment.
haha, good self-question :) , maybe I should walk all lines to figure this out
There was a problem hiding this comment.
@mars1024 any thoughts on whether we can remove startRange?
There was a problem hiding this comment.
yeah, I think startRange is redundant and I'll remove it
…i ranges Signed-off-by: Bruce Ma <[email protected]>
mars1024
force-pushed
the
bugfix/wrong_startrange
branch
from
ff86568
to
b811967
Compare
mars1024
changed the title
|
This looks awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref to #579 , just try another way to fix the same issue. Here is the details #579 (comment).
Signed-off-by: Bruce Ma [email protected]
Fixes #594