run: add container gid to additional groups
#4200
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
flouthoc
force-pushed
the
run-set-additional-gid
branch
2 times, most recently
from
b4b6742
to
64106cf
Compare
|
Added additional test for |
flouthoc
force-pushed
the
run-set-additional-gid
branch
from
64106cf
to
e7a4eb2
Compare
|
@nalind PTAL again. |
tests/bud.bats
Outdated
|
|
||
| @test "build test if supplemental groups has gid with --isolation chroot" { | ||
| skip_if_rootless_environment | ||
| skip_if_no_runtime |
There was a problem hiding this comment.
Are either of these conditions required for this test?
There was a problem hiding this comment.
Other tests which have --isolation chroot are being skipped for similar scenarios that's why i added it, I can try removing it.
There was a problem hiding this comment.
I think we should probably try to remove them from all of the chroot tests.
There was a problem hiding this comment.
Removed from this test, lets see if CI is happy. I'll do this for all the other tests in a different PR since they are not part of this PR.
|
LGTM |
When container is created with specific uid and gid also add container gid to supplementary/additional group. Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
run-set-additional-gid
branch
from
e7a4eb2
to
9934b17
Compare
|
/lgtm |
|
@flouthoc once a BZ gets spun for this, please add a comment with the BZ number if I neglect to. |
|
Tracked in Red Hat bugzilla at https://bugzilla.redhat.com/show_bug.cgi?id=2121453 |
|
I think we need to get this into Buildah release-1.27 too so we can spin this for 8.7 zero day. |
|
Backport PR here: #4207 |
When container is created with specific
uidandgidalso add containergidto supplementary/additional group.