Unlock mutex before returning from function #24259
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, good catch. But you need to add a signoff to your commit ( |
emakrushin
force-pushed
the
containers
branch
from
30d2c75
to
af0a6ee
Compare
I'll also throw this on Podman.io and maybe write a short blog about it there. Signed-off-by: Matt Heon <[email protected]>
mapMutex is initialized in the ContainerRm function and cannot be released from outside, thus unlock mutex before returning from function. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Егор Макрушин <[email protected]>
emakrushin
force-pushed
the
containers
branch
from
af0a6ee
to
06b470d
Compare
|
approved not having a test. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, emakrushin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapMutex is initialized in the ContainerRm function and cannot be released from outside,
thus unlock mutex before returning from function.
Does this PR introduce a user-facing change?