Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hirtectl config #131

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Fix hirtectl config #131

merged 1 commit into from
Jul 26, 2023

Conversation

Yarboa
Copy link
Collaborator

@Yarboa Yarboa commented Jul 26, 2023

During inspection of systemctl start qm failures
It seems that config files were not set properly due to regexp inaccuracies

@Yarboa
Fix hirtectl config
cd5b858 
During inspection of systemctl start qm failures
It seems that config files were not set properly due to
regexp inaccuracies

Signed-off-by: Yariv Rachmani <[email protected]>
dougsland
dougsland approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@dougsland dougsland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yaniv, it's related to the new hirte config load from sources feature. Great catch!

@dougsland dougsland merged commit 9e2a056 into containers:main Jul 26, 2023
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougsland dougsland dougsland approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@lsm5 lsm5 Awaiting requested review from lsm5 lsm5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yarboa @dougsland