Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve prepare_images and increase duration #507

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

pengshanyu
Copy link
Collaborator

  1. When each test case is executed, if directory /var/qm/lib/containers/registry exists, delete it first, then create the directory and copy the ffi-tools container image to it.
  2. Pulling ffi-tools image often times out, so extend the duration.

Resolve #506

Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we should consider shrinking ffi-tools
I mean move more rpms into the condition, @pengshanyu, WDYT?

@dougsland
Copy link
Collaborator

@nsednev maybe you need this patch?

@pengshanyu
Copy link
Collaborator Author

pengshanyu commented Aug 22, 2024

I assume we should consider shrinking ffi-tools I mean move more rpms into the condition, @pengshanyu, WDYT?

Yes, let's try to shrink ffi-tools. I am not familiar with some packages, could you give me some guidance?

@dougsland
Copy link
Collaborator

safe to merge, helping reduce the size. CI/CD might be get better with the patch btw. @Yarboa will provide in an Github Issue maybe? ideas for improvement for reducing the size?

@dougsland dougsland merged commit 8888375 into containers:main Aug 22, 2024
6 of 9 checks passed
@pengshanyu pengshanyu deleted the update-copy-ffi-tools branch August 26, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurred while copying the ffi-tools image to /var/qm/lib/containers
3 participants