-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In admin the fetch of collection times fails if collection time is outside the window #50
Comments
@jacquesbh I'm also bumping into this issue, your quickfix assumes the duration didn't change, does it not? It seems better to also just save the collection end date and not have the admin use the computer at all? |
My fix is a quick fix to bypass the issue. It's not a proper fix :(. |
Thanks for the response! I'm currently saving the start and end time and took out the checks so the admin area doesn't rely on the location settings. Seems more correct this way. |
Description
Let's say a customer saves a collection time for 7am UTC in 10 days.
Then later today the merchant changes the location hours and excludes the 7am UTC.
Then in admin you'll get an exception when you try to get all the collection times.
How to reproduce
Follow steps listed above.
Possible Solution
Solution is just not to validate the collection time in admin: if you have a collection time then the merchant MUST know.
→ quick fix here: 1e32bf2
The text was updated successfully, but these errors were encountered: