Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullname template is not ignoring duplicate coredns string in it #155

Closed
den-is opened this issue Dec 28, 2023 · 0 comments · Fixed by #156
Closed

fullname template is not ignoring duplicate coredns string in it #155

den-is opened this issue Dec 28, 2023 · 0 comments · Fixed by #156

Comments

@den-is
Copy link
Contributor

den-is commented Dec 28, 2023

Currently if helm release/instance is named same as the chart, coredns, it keeps that duplicate string in the fullname template.
So all objects created by this chart have not that smart naming.
The standard is to not include the release name string in the fullname template.

Current object names, when helm release is named coredns:

kubectl -n kube-system get all,sa,clusterrole,clusterrolebinding,smon -l app.kubernetes.io/instance=coredns
NAME                                   READY   STATUS    RESTARTS      AGE
pod/coredns-coredns-6db9976d78-drpdc   1/1     Running   1 (11h ago)   15h

NAME                              TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)         AGE
service/coredns-coredns-metrics   ClusterIP   10.30.232.118   <none>        9153/TCP        15h
service/kube-dns                  ClusterIP   10.30.0.10      <none>        53/UDP,53/TCP   15h

NAME                              READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/coredns-coredns   1/1     1            1           15h

NAME                                         DESIRED   CURRENT   READY   AGE
replicaset.apps/coredns-coredns-6db9976d78   1         1         1       15h

NAME                             SECRETS   AGE
serviceaccount/coredns-coredns   0         15h

NAME                                                    CREATED AT
clusterrole.rbac.authorization.k8s.io/coredns-coredns   2023-12-27T13:55:55Z

NAME                                                           ROLE                          AGE
clusterrolebinding.rbac.authorization.k8s.io/coredns-coredns   ClusterRole/coredns-coredns   15h

NAME                                                   AGE
servicemonitor.monitoring.coreos.com/coredns-coredns   15h

You can see that coredns-coredns is everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant