-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate merged/replaced Ignition configs if they're local/inline #275
Comments
FWIW I believe I hit this exact problem recently with a snippet like:
I found an example elsewhere online that made me realize merged configs are meant to contain ignition and not butane. It would be very helpful if examples.md illustrated this merge+local scenario. |
There's a complication: it's valid to embed an Ignition config with a version newer than the ones Butane knows about. We should probably not reject such configs. To handle that, I think it makes sense to catch |
When merging/replacing a
local
orinline
config, we already have the config contents, so we should run it through Ignition config validation to catch problems early. (For example, the user may have provided a Butane config by mistake.)The text was updated successfully, but these errors were encountered: