install: restrict access permissions on /boot/ignition{,/config.ign} #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travier
reviewed
Jul 6, 2021
bgilbert
changed the title
|
Updated. |
travier
approved these changes
Jul 7, 2021
|
This might benefit from a conversion to https:/coreos/openat-ext but this can definitely be done later. |
jlebon
approved these changes
Jul 7, 2021
|
Probably worth mentioning coreos/fedora-coreos-tracker#889 in the commit message for posterity. On the other side of this, we should consider deleting the file after it's used. This is discussed in the tracker issue. |
The Ignition config may contain secrets. Don't expose it, or anything in its parent directory, to unprivileged processes. coreos/fedora-coreos-tracker#889
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Jul 13, 2021
jlebon
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Jul 13, 2021
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ignition config may contain secrets. Don't expose it, or anything in its parent directory, to unprivileged processes.