This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
docs: delete unnecessary go get #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I don't think we need jenkins for this one since it doesn't have any coverage of docs anyways. The change LGTM, other than that the commit message doesn't match the usual format (mentioned here). If you're willing to include the Thanks! |
|
@jakon89 any chance you'd be able to tweak the commit message as Euan mentioned? |
|
@jonboulle sure, let me modify my commit |
|
Can one of the admins verify this patch? |
|
It looks that I did something wrong with my fork of rkt. Is there any chance to open this PR again or should I create new one? |
go get step is unnecessary after migration to glide Fixes rkt#3499
|
Looks great now. Thanks so much! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
As mentioned in #3499
go getis not required anymore.