This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
tests/rkt_stop: Wait for 'stop' command to complete #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not just 'fire-and-forget' the issuing of the 'stop' command, but wait for it to complete, or fail. From testing, it would appear that not waiting for the command to complete may be responsible for the spurious hangups seen during CI testing, which may be attributed to not draining the tty of the command via gexpect. Signed-off-by: Graham Whaley <[email protected]>
|
@lucab PTAL |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the 'stop' command to complete before checking run status.
AFAICT,
Fixes #3091
Signed-off-by: Graham Whaley [email protected]