This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
tests: use appc schema instead of string templates #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
lucab
suggested changes
Jan 10, 2017
| return NewACI(dir, manifest, nil) | ||
| manifest := schema.ImageManifest{ | ||
| ACKind: schema.ImageManifestKind, | ||
| ACVersion: SpecVersion, |
There was a problem hiding this comment.
Appc version labels use to be updated via a script. Can we turn this back into a string and use NewSemVer()?
There was a problem hiding this comment.
You mean, the SpecVersion variable, like this:
var SpecVersion, _ = types.NewSemVer("0.8.9")There was a problem hiding this comment.
Yes, sorry if I was a bit cryptic.
|
@ybubnov thank you very much for this PR. Just a minor request to make the version label manageable by script, otherwise looks fine 👍. |
|
@jonboulle is there anything else missing from #714 after this? |
|
Seems good to me! |
|
Addressed the review comments and squashed the changes into the single commit. |
|
Ah, I forgot about |
This patch introduces a new package "pkg/aci/acitest" used to set the default parameters to the application container image manifest (precisely: name, version, kind). It replaces the strings templates used to mock the manifest's JSON to the types from "github.com/appc/schema" go-package.
lucab
approved these changes
Jan 13, 2017
lucab
added
kind/cleanup
reviewed/lgtm
reviewed/merge-on-green
and removed
needs/some-changes
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a new package "pkg/aci/acitest" used to set the
default parameters to the application container image manifest
(precisely: name, version, kind).
It replaces the strings templates used to mock the manifest's JSON to
the types from "github.com/appc/schema" go-package.
Fixes #714