Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: Add spinner/progress for layer fetches #4962

Merged
merged 1 commit into from
May 15, 2024

Conversation

cgwalters
Copy link
Member

This at least gives us a spinner when we're fetching layers, so folks know something is happening.

As the comment says we can get byte-level progress, but it just needs more plumbing work with our complex internal output infrastructure.

Note that I had to move the layer progress bits into a tokio LocalSet because the progress output stuff is a thread local.

This at least gives us a spinner when we're fetching
layers, so folks know something is happening.

As the comment says we *can* get byte-level progress, but
it just needs more plumbing work with our complex internal
output infrastructure.

Note that I had to move the layer progress bits into a
tokio LocalSet because the progress output stuff is
a thread local.

Signed-off-by: Colin Walters <[email protected]>
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero enabled auto-merge May 14, 2024 23:40
output_message(&msg);
tracing::debug!("layer progress: {msg}");
match v {
ImportProgress::OstreeChunkStarted(_) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other tech debt here is that this would all blow up if we started fetching layers concurrently. Ultimately we're going to switch to using podman via containers/bootc#215 so we can ignore this.

@jmarrero jmarrero merged commit 87b1775 into coreos:main May 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants