Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the as property in the CFooter component to use semantic tag #289

Merged
merged 1 commit into from
May 30, 2024
Merged

Add the as property in the CFooter component to use semantic tag #289

merged 1 commit into from
May 30, 2024

Conversation

cesargb
Copy link
Contributor

@cesargb cesargb commented May 30, 2024

The component CFooter write the tag div, with this custom property we can use footer tag

<CFooter>My footer</CFooter>
// Out put: <div class="footer">My footer</div>

<CFooter as="footer">My footer</CFooter>
// Out put: <footer class="footer">My footer</footer>

@cesargb cesargb changed the title Add the 'as` property in the CFoooter component to use semantic tag Add the as property in the CFoooter component to use semantic tag May 30, 2024
@cesargb cesargb changed the title Add the as property in the CFoooter component to use semantic tag Add the as property in the CFoooter component to use semantic tag May 30, 2024
@cesargb cesargb changed the title Add the as property in the CFoooter component to use semantic tag Add the as property in the CFooter component to use semantic tag May 30, 2024
@mrholek mrholek merged commit 7d80cc6 into coreui:main May 30, 2024
@cesargb cesargb deleted the tag_semantic branch May 31, 2024 07:03
@cesargb cesargb mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrholek mrholek mrholek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cesargb @mrholek